Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dropdown/lookup & lookup-name fields being reset when hitting enter #3724

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Fixed dropdown/lookup & lookup-name fields being reset when hitting enter #3724

merged 3 commits into from
Jan 3, 2025

Conversation

alexandrevryghem
Copy link
Member

References

Description

Fixed issue where hitting enter in a submission form containg a dropdown/lookup or lookup-name field would cause the first one to reset.

Instructions for Reviewers

List of changes in this PR:

  • Added type="button" to the buttons in those dropdowns, this prevents them from being triggered on submit
  • Also added another small fix to the FormService class. The AbstractControl's errors property can be null when there are no errors, and this caused an issue when it was null because then Object.keys(null) was being called

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem
119799: Prevent submission from updating the dropdown values when hit…
ed4e794 
…ting enter in another input form (onsubmit)
@alexandrevryghem
Merge remote-tracking branch 'alex/w2p-122005_fixed-dropdown-values-r…
c12a3e6 
…esetting-on-enter_contribute-7.6'

# Conflicts:
#	src/app/shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.html
@alexandrevryghem
119799: Prevent the lookup/lookup-name fields from resetting when hit…
c8694e1 
…ting the enter key in another input field
@alexandrevryghem alexandrevryghem added bug component: submission component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Dec 7, 2024
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Dec 7, 2024
@alexandrevryghem alexandrevryghem self-assigned this Dec 7, 2024
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Dec 9, 2024
nwoodward
nwoodward approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem! I tested this PR locally, and it fixes the bug in the form.

@alanorth
Copy link
Contributor

alanorth commented Jan 3, 2025

Thanks @alexandrevryghem! Merging as this is 1 APPROVAL pull request only requires a single approval to merge and has been tested by @nwoodward and is passing all tests in CI. Thanks both.

@alanorth alanorth merged commit 2cde0d3 into DSpace:main Jan 3, 2025
25 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3724-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3724-to-dspace-7_x
git switch --create backport-3724-to-dspace-7_x
git cherry-pick -x ed4e794d466cec87ec9f7029f59165ff12409174 c8694e1a87ab6ad70ef0f984a77f3e12dbd5605d

@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3724-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3724-to-dspace-8_x
git switch --create backport-3724-to-dspace-8_x
git cherry-pick -x ed4e794d466cec87ec9f7029f59165ff12409174 c8694e1a87ab6ad70ef0f984a77f3e12dbd5605d

@alanorth
Copy link
Contributor

alanorth commented Jan 3, 2025

Dear @alexandrevryghem, automatic backports for this to dspace-8_x and dspace-7_x have failed. If you have time would you be willing to create patches for these branches manually? Thank you!

@alexandrevryghem alexandrevryghem deleted the w2p-122005_fixed-dropdown-values-resetting-on-enter_contribute-main branch January 3, 2025 09:12
@alexandrevryghem alexandrevryghem mentioned this pull request Jan 3, 2025
Merged
@alexandrevryghem alexandrevryghem removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Jan 3, 2025
@alexandrevryghem alexandrevryghem mentioned this pull request Jan 3, 2025
Merged
@alexandrevryghem alexandrevryghem removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwoodward nwoodward nwoodward approved these changes

Assignees

@alexandrevryghem alexandrevryghem

Labels
1 APPROVAL pull request only requires a single approval to merge bug component: controlled vocabulary related to controlled vocabulary or value-pairs dropdowns component: submission
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

Dropdown/lookup & lookup-name values are reset when hitting enter
5 participants
@alexandrevryghem @alanorth @dspace-bot @nwoodward @tdonohue